Skip to content

CLN: test_moments_consistency_*.py #36810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2020
Merged

CLN: test_moments_consistency_*.py #36810

merged 4 commits into from
Oct 2, 2020

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

In-lining some common functions to make it easier to follow test failure tracebacks

@mroeschke mroeschke added Clean Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding labels Oct 2, 2020
@mroeschke mroeschke added this to the 1.2 milestone Oct 2, 2020
jreback
jreback approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. ping on green.

@jreback jreback merged commit ace2bdd into pandas-dev:master Oct 2, 2020
@jreback
Copy link
Contributor

jreback commented Oct 2, 2020

thanks!

@mroeschke mroeschke deleted the clean/moments_consistency branch October 2, 2020 21:42
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@mroeschke
CLN: test_moments_consistency_*.py (pandas-dev#36810)
9233e3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jreback