BUG: Fix FloatingArray output formatting #36800
Conversation
simonjayhawkins
added
NA - MaskedArrays
| @@ -3432,3 +3432,14 @@ def test_format_remove_leading_space_dataframe(input_array, expected): | |||
| # GH: 24980 | |||
| df = pd.DataFrame(input_array).to_string(index=False) | |||
| assert df == expected | |||
|
|
|||
|
|
|||
| def test_nullable_float_to_string(float_ea_dtype): | |||
There was a problem hiding this comment.
i think should move these to EA tests and try to do these generically (for all of the numberic types); i guess ok here as well (but group them together int. & float both with and w/o nulls)
There was a problem hiding this comment.
do we have int nullable tests for formatting?
There was a problem hiding this comment.
Not as far as I can tell, entirely possible I'm just missing them
There was a problem hiding this comment.
kk can you add (this PR would be great)
There was a problem hiding this comment.
Done. These tests could probably be cleaned up a bit also, this file is very big and testing lots of different things.
There was a problem hiding this comment.
oh yes, for sure. if you'd create an issue would be great.
…ray-string-format
…ray-string-format
| @@ -3432,3 +3432,14 @@ def test_format_remove_leading_space_dataframe(input_array, expected): | |||
| # GH: 24980 | |||
| df = pd.DataFrame(input_array).to_string(index=False) | |||
| assert df == expected | |||
|
|
|||
|
|
|||
| def test_nullable_float_to_string(float_ea_dtype): | |||
There was a problem hiding this comment.
do we have int nullable tests for formatting?
|
thanks @dsaxton |
|
Thanks @dsaxton ! |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff