BUG: Rolling returned nan with FixedForwardWindowIndexer for count when window contained only missing values #36787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

phofl wants to merge 1 commit into pandas-dev:master from phofl:35579

Member

phofl commented Oct 1, 2020 •

edited

Loading

closes BUG: rolling count on FixedForwardWindowIndexer returns NaN instead of 0 #35579
tests added / passed
passes black pandas
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

Issue still has milestone 1.1.3. If it's to late for this release, I'll move the whats new note to 1.1.4 for when the associated PR is merged.


          Fix bug with empty windows with count and FixedForwardWindowIndexer

47e567b

phofl added the Window label

Member Author

phofl commented Oct 1, 2020

Have just seen #36649 which will close the issue.

phofl closed this

phofl deleted the 35579 branch

October 1, 2020 21:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Window