BUG: fix inconsistent col spacing in info #36766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanovmg
changed the title
jreback
requested changes
Oct 2, 2020
|
It is dependent, but the problem was that the width of the string with the column number is the actual width of the number + 1 space (Line 342 of the original file shows that line number string is prepended with a space). This PR fixes the problem and makes consistent spacing even when the number of columns is over 1000. |
ivanovmg
commented
Oct 3, 2020
| # add one space in max_id because there is a one-space padding | ||
| # in front of the number | ||
| # this allows maintain two spaces gap between columns | ||
| max_id = len(pprint_thing(col_count)) + 1 |
There was a problem hiding this comment.
Note that this was starting playing role only when number of columns was over 1000. Because below 1000 max_id < len_id. Therefore below 1000 columns there were no issues.
jreback
requested changes
Oct 7, 2020
jreback
approved these changes
Oct 7, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff