Skip to content

BUG: inconsistent name-retention in Series ops #36760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2020

Conversation

jbrockmendel
Copy link
Member

As a follow-up I think we can remove a bunch of name-based tests from tests.arithmetic.

@jreback jreback added the API - Consistency Internal Consistency of API/Behavior label Oct 2, 2020
@jreback jreback added this to the 1.2 milestone Oct 2, 2020
@jreback
Copy link
Contributor

jreback commented Oct 2, 2020

great. can you add a whatsnew note and ping on green. i would specific mentions of broken operators is ok (or is this all binary ops)?

@jbrockmendel
Copy link
Member Author

ping

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. merge on green.

@jbrockmendel jbrockmendel merged commit da3a2d3 into pandas-dev:master Oct 7, 2020
@jbrockmendel jbrockmendel deleted the bug-ops-res-names branch October 7, 2020 15:00
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
* BUG: inconsistent name-retention in Series ops

* whatsnew

Co-authored-by: Jeff Reback <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Consistency Internal Consistency of API/Behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Inconsistent name of binary operations between Series and ndarray, list, tuple
2 participants