CLN: use standard method to set unhashable object #36717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 30, 2020
pandas/core/generic.py
Outdated
| f"{repr(type(self).__name__)} objects are mutable, " | ||
| f"thus they cannot be hashed" | ||
| ) | ||
| __hash__ = None |
There was a problem hiding this comment.
can you add a comment / ref for this
jreback
added
the
Compat
|
ci checks is failing as well |
If hash=None is the desired way to indicate unhashable object, this could be a mypy issue. |
|
xref python/mypy#4266 |
|
close for now. It doesn't work with mypy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20589 mentioned lgtm. So I decided to test it. And it found this potential improvement. There is even a detailed reference with code examples. https://lgtm.com/rules/1780095/ Very interesting.
Just trying to see if their suggestion works.