Skip to content

[MRG] TST: Added test for groupby apply datetimeindex fix #36671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2020
Merged

[MRG] TST: Added test for groupby apply datetimeindex fix #36671

merged 2 commits into from
Oct 2, 2020

Conversation

amy12xx
Copy link
Contributor

@amy12xx amy12xx commented Sep 26, 2020 •
edited
Loading

worked on by @ezebunandu and @amy12xx

arw2019
arw2019 reviewed Sep 26, 2020
View reviewed changes
Copy link
Member

@arw2019 arw2019 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good.

Small nit: I'd move it up a bit in the file to sit with other similar tests (next to test_apply_aggregating_timedelta_and_datetime for example).

@amy12xx amy12xx changed the title TST: Added test for groupby apply datetimeindex fix [MRG] TST: Added test for groupby apply datetimeindex fix Sep 27, 2020
@amy12xx
Copy link
Contributor Author

amy12xx commented Oct 1, 2020

@arw2019 made the change. Let me know if you have any other comments. Thanks.

@mroeschke mroeschke merged commit 4ab9288 into pandas-dev:master Oct 2, 2020
@jreback jreback added Apply Apply, Aggregate, Transform, Map Groupby Datetime Datetime data dtype Testing pandas testing functions or related to the test suite labels Oct 2, 2020
@mroeschke
Copy link
Member

Thanks @amy12xx

@jreback jreback added this to the 1.2 milestone Oct 2, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@amy12xx
[MRG] TST: Added test for groupby apply datetimeindex fix (pandas-dev…
d8e44c1 
…#36671)

* TST: Added test for groupby apply datetimeindex fix

* TST: Moved test to similar tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arw2019 arw2019 arw2019 left review comments

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Datetime Datetime data dtype Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

groupby apply failed on dataframe with DatetimeIndex
4 participants
@amy12xx @mroeschke @arw2019 @jreback