Skip to content

DEPR: DateOffset args don't end in 's' #36660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
+12 −0
Closed

DEPR: DateOffset args don't end in 's' #36660

Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ce983c3
deprecate DateOffset args don't end in 's'
GYHHAHA Sep 26, 2020
880d9df
Update offsets.pyx
GYHHAHA Sep 26, 2020
c248877
Update offsets.pyx
GYHHAHA Sep 26, 2020
dcca70b
Update offsets.pyx
GYHHAHA Sep 26, 2020
947a7e4
add weekday permission
GYHHAHA Sep 27, 2020
734524c
change warning description
GYHHAHA Oct 2, 2020
4ec6848
update 1.2.0 whatsnew
GYHHAHA Oct 2, 2020
7c7d0b4
Merge branch 'master' into patch-2
GYHHAHA Oct 2, 2020
6d728ff
Update offsets.pyx
GYHHAHA Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pandas/_libs/tslibs/offsets.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,16 @@ cdef _determine_offset(kwds):
'year', 'month', 'week', 'day', 'weekday',
'hour', 'minute', 'second', 'microsecond')

if any(not k.endswith('s') for k in kwds_no_nanos):
if 'weekday' not in kwds_no_nanos:
warnings.warn(
"The DateOffset arguments that do not end in 's' replace "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd write Use of Date Offset arguments that do not end with 's' overwrites the offset instead of incrementing it. These arguments are deprecated now and slated for removal in a future version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. I will make the change.

"the offset value instead of making an addition. They are "
"deprecated now and slated for removal in the future.",
FutureWarning,
stacklevel=1,
)

use_relativedelta = False
if len(kwds_no_nanos) > 0:
if any(k in _kwds_use_relativedelta for k in kwds_no_nanos):
Expand Down