-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: DataFrame.pivot drops column level names when both rows and columns are multiindexed #36655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
8bb215c
handle column index construction for MultiIndex
arw2019 47b223f
add test
arw2019 433318a
whatsnew
arw2019 d02eace
remove special casing in _wrap_aggregated_output
arw2019 10dff12
drop the if-else clause
arw2019 25cfc8e
handle name='[[None]' in Index constructor
arw2019 074f99e
revert changes to Index constructor
arw2019 c2d5f9e
use _get_names() in column Index constructor
arw2019 14bfdc9
use _set_index in _wrap_aggregated_output
arw2019 050de4a
merge with upstream/master
arw2019 73359cc
Merge remote-tracking branch 'upstream/master' into GH36360
arw2019 05aa018
Merge remote-tracking branch 'upstream/master' into GH36360
arw2019 cac6d55
Merge remote-tracking branch 'upstream/master' into GH36360
arw2019 4c9b3ae
Merge remote-tracking branch 'upstream/master' into GH36360
arw2019 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have appropraite tests if index OR columns are a MI and the other is not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do (in this file and in
test_pivot.py
)What existing tests don't cover is the case when
pivot_table
produces a result with multiple MutliIndexed columns - added here