CLN: dont special-case DatetimeArray indexing #36654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Indexing
|
can you add some tests that lock this down (eg from the OP). I think this would be ok to push for 1.2 with a whatsnew note. |
|
whatsnew+test+green |
|
any other thoughts here? after this i can get back to de-duplicating EA code |
jreback
reviewed
Oct 10, 2020
| def test_getitem_boolean_dt64_copies(): | ||
| # GH#36210 | ||
| dti = date_range("2016-01-01", periods=4, tz="US/Pacific") | ||
| key = np.array([True, True, False, False]) |
There was a problem hiding this comment.
can you replicate the OP here as well (e.g. add the slice test for this too)
There was a problem hiding this comment.
not sure i understand. this is exactly the example from the OP
There was a problem hiding this comment.
the OP had 2 example inputs
ser1 = pd.Series(dti._data)
ser2 = pd.Series(range(4))
|
Test amended + green |
jreback
approved these changes
Oct 12, 2020
|
Thanks Brock! |
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Oct 26, 2020
* CLN: dont special-case DatetimeArray indexing * use parent class _validate_getitem_key * test, whatsnew * update test
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* CLN: dont special-case DatetimeArray indexing * use parent class _validate_getitem_key * test, whatsnew * update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffcc @jorisvandenbossche