TST: GH 32431 check print label indexing on nan #36635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Sep 25, 2020
| # GH 32431 | ||
| df = pd.Series([1, "{1,2}", 1, None]) | ||
| vc = df.value_counts(dropna=False) | ||
| print(vc.loc[np.nan]) |
There was a problem hiding this comment.
Rather than just printing you should construct the expected result and use tm.assert_series_equal(result, expected) - you should see this idiom throughout the test modules if you need a reference
There was a problem hiding this comment.
Thanks for the feedback! I constructed the expected result and expected an int. So I compared the results just with a normal assert, since I couldn't find a method on tm to assert ints. Please let me know if this satisfies your request
WillAyd
approved these changes
Sep 29, 2020
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
thanks @wesleyboelrijk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis is my first contribution to pandas. I added a simple test that was requested in one of the open issues.