Skip to content

Replace single with double backticks in RST file #36617 #36632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Sep 26, 2020

Conversation

Shubhamsm
Copy link
Contributor

@Shubhamsm Shubhamsm commented Sep 25, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

closes #36617

@Shubhamsm
Copy link
Contributor Author

Replaces single with double backticks

doc/source/user_guide/10min.rst
doc/source/user_guide/timeseries.rst
doc/source/user_guide/visualization.rst
doc/source/user_guide/missing_data.rst
doc/source/user_guide/options.rst
doc/source/user_guide/reshaping.rst
doc/source/user_guide/scale.rst
doc/source/user_guide/merging.rst
doc/source/user_guide/cookbook.rst
doc/source/user_guide/enhancingperf.rst
doc/source/user_guide/groupby.rst
doc/source/user_guide/io.rst
doc/source/getting_started/overview.rst
doc/source/reference/panel.rst
doc/source/reference/plotting.rst
doc/source/user_guide/10min.rst
doc/source/user_guide/basics.rst
doc/source/user_guide/categorical.rst
doc/source/development/contributing.rst
doc/source/development/contributing_docstring.rst
doc/source/development/extending.rst
doc/source/ecosystem.rst
doc/source/getting_started/comparison/comparison_with_sql.rst
doc/source/getting_started/install.rst
doc/source/getting_started/intro_tutorials/06_calculate_statistics.rst

@Shubhamsm
Copy link
Contributor Author

@dsaxton Can I ask why this test is failing?
Is this Issue solved?

@Shubhamsm
Copy link
Contributor Author

Hi @dsaxton , I've removed many unnecessary backticks
now I cann't find problems that are failing the test.
can you tell me what other problems I'd made in the commits

Copy link
Member

@dsaxton dsaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to say with so many changes what would make the doc build pass. Part (but perhaps not all) of the reason is these warnings (CI fails if warnings are raised during the doc build), so you could start by fixing those:

2020-09-25T18:31:10.2551420Z Differences to R's ``factor``
2020-09-25T18:31:10.2552161Z ---------------------------
2020-09-25T18:31:10.2553014Z /home/runner/work/pandas/pandas/doc/source/user_guide/categorical.rst:1016: WARNING: Title underline too short.

@dsaxton
Copy link
Member

dsaxton commented Sep 26, 2020

Can you also merge master? Several files were just fixed.

@Shubhamsm
Copy link
Contributor Author

@dsaxton thank you. done the changes

Copy link
Member

@dsaxton dsaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shubhamsm, nice PR!

@Shubhamsm
Copy link
Contributor Author

Shubhamsm commented Sep 26, 2020

@dsaxton thank you for your help 😄
love to contribute something to pandas

@dsaxton dsaxton merged commit 227cf91 into pandas-dev:master Sep 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: Replace single with double backticks in RST files
2 participants