Skip to content

CI: add py38 slow build #35160 #36626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 7, 2020
Merged

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Sep 25, 2020

This issue was created before we dropped py36 support. So I think we should add equivalent CI build for py38.

@jreback
Copy link
Contributor

jreback commented Sep 25, 2020

can u out this on azure instead? we have more parallelism there - and they are slightly less opaque than travis

@fangchenli
Copy link
Member Author

can u out this on azure instead? we have more parallelism there - and they are slightly less opaque than travis

I'll look at how to set up sql on azure. It's more straightforward to do this on Travis.

@jreback
Copy link
Contributor

jreback commented Sep 25, 2020

@fangchenli another alternative is to move one of the other travis builds to azure if that's easier.

@jreback jreback added the CI Continuous Integration label Sep 25, 2020
@jreback jreback added this to the 1.2 milestone Oct 3, 2020
@jreback
Copy link
Contributor

jreback commented Oct 3, 2020

can you rebase; also is the 3.7_locale duplicated in azure & travis? (or is it different)?

@fangchenli
Copy link
Member Author

can you rebase; also is the 3.7_locale duplicated in azure & travis? (or is it different)?

The one on travis has sql related tests. Maybe we can combine those two.

Comment on lines +41 to +42
- moto
- flask
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two were in the auzre-37-locale build.

Comment on lines -46 to -50
# py37_32bit:
# ENV_FILE: ci/deps/azure-37-32bit.yaml
# CONDA_PY: "37"
# PATTERN: "not slow and not network and not clipboard"
# BITS32: "yes"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conda doesn't have 32bit build anymore.

Comment on lines 43 to -47
- env:
- JOB="3.8" ENV_FILE="ci/deps/travis-38.yaml" PATTERN="(not slow and not network and not clipboard)"

- env:
- JOB="3.7" ENV_FILE="ci/deps/travis-37.yaml" PATTERN="(not slow and not network and not clipboard)"
Copy link
Member Author

@fangchenli fangchenli Oct 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two are not using any travis services.

@jreback
Copy link
Contributor

jreback commented Oct 6, 2020

ok this lgtm. can you merge master to retrigger and ping on green.

@jreback jreback merged commit 505f937 into pandas-dev:master Oct 7, 2020
@jreback
Copy link
Contributor

jreback commented Oct 7, 2020

thanks @fangchenli

@fangchenli fangchenli deleted the py38-slow-travis branch October 10, 2020 21:32
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: add sql tests back to py36
2 participants