CLN: de-duplicate numeric type check in _libs/testing #36625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 26, 2020
pandas/_libs/testing.pyx
Outdated
|
|
||
| cdef bint is_comparable_as_number(obj): | ||
| return isinstance(obj, NUMERIC_TYPES) | ||
| cdef bint is_comparable_as_real_number(obj): |
There was a problem hiding this comment.
is wouldn't even do this, just use the imported one directly.
There was a problem hiding this comment.
not a huge deal, but unless we expect to use it elsewhere, id rather this new func live here rather than in util; otherwise it gets re-compiled into basically every cython module.
jreback
added
Clean
Testing
|
looks good, still some lint issues, ping on green (small comment) |
|
Green |
|
@arw2019 can you merge master |
|
Sorry to have been quiet! Merged again just now - all green |
|
thanks @arw2019 |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffIn
testing.pyxwe keep a list of numeric dtypes and use that for type checking. But we have functions that do this intslibs/util.pxdso it's better to use those instead