Skip to content

CLN: Avoid importing Series in core.aggregation #36612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Breaks import cycles allowing aggregation to be imported at the top.

@rhshadrach rhshadrach added Apply Apply, Aggregate, Transform, Map Clean labels Sep 24, 2020
@jreback jreback added this to the 1.2 milestone Sep 24, 2020
@jreback jreback merged commit 209c29e into pandas-dev:master Sep 24, 2020
@jreback
Copy link
Contributor

jreback commented Sep 24, 2020

thanks @rhshadrach

@rhshadrach rhshadrach deleted the aggregation_imports branch September 26, 2020 12:00
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apply Apply, Aggregate, Transform, Map Clean
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants