Skip to content

CI: rerun flaky test in html #36467 #36607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

CI: rerun flaky test in html #36467 #36607

wants to merge 3 commits into from

Conversation

fangchenli
Copy link
Member

Part of #36467

@WillAyd
Copy link
Member

WillAyd commented Sep 24, 2020

Hmm so is this test failing or just sometimes leaking a resource? If the latter it seems like there is an issue elsewhere we need to find

@WillAyd WillAyd added the IO HTML read_html, to_html, Styler.apply, Styler.applymap label Sep 24, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label Sep 24, 2020
@fangchenli
Copy link
Member Author

Hmm so is this test failing or just sometimes leaking a resource? If the latter it seems like there is an issue elsewhere we need to find

The coverage build generates many many ResourceWarnings (I wonder if it has something to do with the coverage plugin). This test just happens to have an assert_produces_warning in it. Therefore it's the only one that failed.

@WillAyd
Copy link
Member

WillAyd commented Sep 25, 2020

This test just happens to have an assert_produces_warning in it.

We have quite a few tests that would do this though, no?

@jreback
Copy link
Contributor

jreback commented Oct 2, 2020

Hmm so is this test failing or just sometimes leaking a resource? If the latter it seems like there is an issue elsewhere we need to find

The coverage build generates many many ResourceWarnings (I wonder if it has something to do with the coverage plugin). This test just happens to have an assert_produces_warning in it. Therefore it's the only one that failed.

happy to try to fix that, but is this really the fix?

@fangchenli
Copy link
Member Author

I'll take a deeper look at this. Close for now.

@fangchenli fangchenli closed this Oct 2, 2020
@fangchenli fangchenli deleted the flaky-test-html branch October 3, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fangchenli @WillAyd @jreback