CLN: assorted #36606
CLN: assorted #36606
Conversation
Makefile
Outdated
| -python setup.py clean | ||
| -python3 setup.py clean |
There was a problem hiding this comment.
What is the reason for having python3 rather than python?
When using virtual environment, it will be just python.
When working on windows (unluckily) there is python or py or py -3, but no python3.
There was a problem hiding this comment.
when not using a virtualenv on OSX or Linux, python still points at python2
There was a problem hiding this comment.
Thus, it will break make on windows.
What about setting $(PYTHON) variable depending on OS?
https://stackoverflow.com/a/14777895
There was a problem hiding this comment.
Yea I'd rather just keep these as is. I'm pretty sure macOS and most linux distros have or are in the process of removing the standard py2 installation, so this is adding what will soon be legacy code style
There was a problem hiding this comment.
Does make even work on windows?
There was a problem hiding this comment.
It is possible to use make on windows. I use it. in GitBash terminal (MinGW) it works almost as in bash.
There was a problem hiding this comment.
deal breaker? i think osx/linux use case is more common, but not a hill worth dying on.
|
lgtm. @ivanovmg has a comment |
|
reverted non-unanimous bit |
|
lgtm. whats up with the py38_np_dev build, any idea? |
Looks like a new exception message |
* docstring fixups, closes pandas-dev#26982 * update RangeIndex docstring, closes pandas-dev#22373 * CLN: misc * CLN: update Makefil * update nat docstrings to match * revert controversial
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff