BUG: propagate dropna in pd.Grouper #36604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
arw2019
force-pushed
the
GH35612-grouper
branch
from
ae57e06 to
ff6e013
Compare
rhshadrach
requested changes
Sep 24, 2020
| def test_Grouper_dropna_propagation(dropna): | ||
| df = pd.DataFrame({"A": [0, 0, 1, None], "B": [1, 2, 3, None]}) | ||
| gb = df.groupby("A", dropna=dropna) | ||
| assert gb.grouper.dropna is dropna |
There was a problem hiding this comment.
I think use == instead of is here.
There was a problem hiding this comment.
Also, lowercase g and lets add the PR number here.
There was a problem hiding this comment.
Thanks for looking this over! Fixed both of these
|
I noticed that the I said |
arw2019
changed the title
arw2019
changed the title
WillAyd
reviewed
Sep 25, 2020
jreback
requested changes
Sep 25, 2020
|
The test is fine it was a general question in the PR. Was addressed by Jeff as well so otherwise lgtm
…Sent from my iPhone
On Sep 25, 2020, at 11:49 AM, Richard Shadrach ***@***.***> wrote:
@rhshadrach commented on this pull request.
In pandas/tests/groupby/test_groupby_dropna.py:
> @@ -162,6 +162,13 @@ def test_groupby_dropna_series_by(dropna, expected):
tm.assert_series_equal(result, expected)
***@***.***("dropna", (False, True))
+def test_grouper_dropna_propagation(dropna):
+ df = pd.DataFrame({"A": [0, 0, 1, None], "B": [1, 2, 3, None]})
+ gb = df.groupby("A", dropna=dropna)
+ assert gb.grouper.dropna == dropna
@WillAyd maybe you're thinking we should only be testing the public API and not any internals?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
rhshadrach
approved these changes
Sep 25, 2020
jreback
approved these changes
Sep 26, 2020
|
ok this is fine |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
| @@ -97,6 +98,7 @@ def __init__( | |||
| self.group_keys = group_keys | |||
| self.mutated = mutated | |||
| self.indexer = indexer | |||
| self.dropna = dropna | |||
There was a problem hiding this comment.
@arw2019 this attribute isnt used anywhere except for in the test added in this PR. is it still needed? is it part of a precursor to something on the horizon?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffA precursor to #35751