Skip to content

REF: refactor/cleanup of CSSToExcelConverter #36576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 24, 2020
Merged

REF: refactor/cleanup of CSSToExcelConverter #36576

merged 17 commits into from
Sep 24, 2020

Conversation

ivanovmg
Copy link
Member

@ivanovmg ivanovmg commented Sep 23, 2020 •
edited
Loading

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Refactor/clean up of CSSToExcelConverter in module pandas.io.formats.excel.

  • Move class variables to the top of the class
  • Add font family mapping
  • Extract methods
  • Add missing typing
  • Make color parsing cleaner

@ivanovmg
REF: dict mapping instead of is-elif-else
a1beeea
@ivanovmg
REF: extract method _select_font_family
b15ae56
@ivanovmg
CLN: clean-up size definition
ec73fd8
@ivanovmg
REF: extract method _get_font_names
79620ac
@ivanovmg
CLN: move class attributes on top
14bddca
@ivanovmg
REF: move build_number_format upper
d12f8b7
@ivanovmg
REF: extract method _get_width_name
6541c58
@ivanovmg
REF: simplify logic in _border_style
0b0f8ce
@ivanovmg
TYP: color_to_excel
17ab78c
@ivanovmg
REF: extract methods for handling hex color
b8fbe95
@ivanovmg
REF: extract method _get_decoration
d4f3c20
@ivanovmg
REF: extract methods for bold and italic
2a98ee3 
This was necessary to ensure that mypy does not throw errors.
Mypy does not like chained get operators.
Link to mypy issue:
python/mypy#9430
@ivanovmg
CLN: delete irrelevant comment
151184d
@ivanovmg
REF: extract method _get_is_wrap_text
c8655d0
@ivanovmg
REF: extract method _get_vertical_alignment
73d3f9e
@jreback jreback added IO Excel read_excel, to_excel IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string labels Sep 24, 2020
@jreback jreback added this to the 1.2 milestone Sep 24, 2020
jreback
jreback approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jreback jreback merged commit 5895978 into pandas-dev:master Sep 24, 2020
@ivanovmg ivanovmg deleted the refactor/excel branch October 4, 2020 13:24
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@ivanovmg
REF: refactor/cleanup of CSSToExcelConverter (pandas-dev#36576)
d522211
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@simonjayhawkins simonjayhawkins Awaiting requested review from simonjayhawkins

@jbrockmendel jbrockmendel Awaiting requested review from jbrockmendel

@jorisvandenbossche jorisvandenbossche Awaiting requested review from jorisvandenbossche

Assignees
No one assigned
Labels
IO Excel read_excel, to_excel IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanovmg @jreback