-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN clean ups in code #36570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jbrockmendel
merged 11 commits into
pandas-dev:master
from
erfannariman:cln-remove-whitespace-before-colons
Oct 7, 2020
Merged
CLN clean ups in code #36570
jbrockmendel
merged 11 commits into
pandas-dev:master
from
erfannariman:cln-remove-whitespace-before-colons
Oct 7, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Sep 24, 2020
ivanovmg
reviewed
Sep 25, 2020
jreback
requested changes
Oct 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls limit these changes to a single type per PR, e.g. removing parens in the first 2 files is ok.
thanks @erfannariman |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
* remove redundant paranthesis * parameter copy not used * remove whitespace and unused argument * clean ups in general * changes black * revert changes * close if elif with else * revert pytables * revert parsin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started with whitespaces before colons, ended up doing some other clean ups as well.