Skip to content

REGR: Series.__mod__ behaves different with numexpr #36552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 30, 2020
Merged

REGR: Series.__mod__ behaves different with numexpr #36552

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
41bb091
REGR: Series.__mod__ behaves different with numexpr
simonjayhawkins Sep 22, 2020
14e8b92
Merge remote-tracking branch 'upstream/master' into numexpr-regr
simonjayhawkins Sep 23, 2020
1e2a086
add test
simonjayhawkins Sep 23, 2020
4527d23
release note
simonjayhawkins Sep 23, 2020
ccc7eb6
Merge remote-tracking branch 'upstream/master' into numexpr-regr
simonjayhawkins Sep 25, 2020
85db057
compare result element-wise with Python
simonjayhawkins Sep 25, 2020
ff9e85b
fix test
simonjayhawkins Sep 25, 2020
b904d44
Merge remote-tracking branch 'upstream/master' into numexpr-regr
simonjayhawkins Sep 30, 2020
4f9b91d
use tm.assert_equal
simonjayhawkins Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pandas/core/computation/expressions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,10 @@ def _evaluate_numexpr(op, op_str, a, b):
roperator.rtruediv: "/",
operator.floordiv: "//",
roperator.rfloordiv: "//",
operator.mod: "%",
# we require Python semantics for mod of negative for backwards compatibility
# see https://github.com/pydata/numexpr/issues/365
# so sticking with unaccelerated for now
operator.mod: None,
roperator.rmod: "%",
operator.pow: "**",
roperator.rpow: "**",
Expand Down
2 changes: 0 additions & 2 deletions pandas/core/ops/methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,6 @@ def _create_methods(cls, arith_method, comp_method, bool_method, special):
mul=arith_method(cls, operator.mul, special),
truediv=arith_method(cls, operator.truediv, special),
floordiv=arith_method(cls, operator.floordiv, special),
# Causes a floating point exception in the tests when numexpr enabled,
# so for now no speedup
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message should have been moved in #19649

I think Ok if we have not had reports of floating point exceptions since enabled.

mod=arith_method(cls, operator.mod, special),
pow=arith_method(cls, operator.pow, special),
# not entirely sure why this is necessary, but previously was included
Expand Down