DOC: a few sphinx fixes in release notes #36523
Conversation
|
I've labelled 1.1.3 but only the changes in doc/source/whatsnew/v1.1.3.rst can be backported. |
| @@ -249,7 +249,7 @@ Datetimelike | |||
| - Bug in :class:`DateOffset` where attributes reconstructed from pickle files differ from original objects when input values exceed normal ranges (e.g months=12) (:issue:`34511`) | |||
| - Bug in :meth:`DatetimeIndex.get_slice_bound` where ``datetime.date`` objects were not accepted or naive :class:`Timestamp` with a tz-aware :class:`DatetimeIndex` (:issue:`35690`) | |||
| - Bug in :meth:`DatetimeIndex.slice_locs` where ``datetime.date`` objects were not accepted (:issue:`34077`) | |||
| - Bug in :meth:`DatetimeIndex.searchsorted`, :meth:`TimedeltaIndex.searchsorted`, :meth:`PeriodIndex.searchsorted`, and :meth:`Series.searchsorted` with ``datetime64``, ``timedelta64`` or ``Period`` dtype placement of ``NaT`` values being inconsistent with ``NumPy`` (:issue:`36176`,:issue:`36254`) | |||
There was a problem hiding this comment.
can you move notes in the Other section if possible (to a more relevant section)
There was a problem hiding this comment.
Why is "Datetimelike" not the appropriate section here?
There was a problem hiding this comment.
I think what is being asked is orthogonal to the changes in this PR. will look soon.
There was a problem hiding this comment.
can you move notes in the Other section if possible (to a more relevant section)
doesn't seem possible with clarity.
There was a problem hiding this comment.
this was a general request, nothing to do with this PR really. but since you are changing things anyways in the whatsnew it would make sense. but can do later too.
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -271,7 +271,8 @@ Numeric | |||
| - Bug in :func:`to_numeric` where float precision was incorrect (:issue:`31364`) | |||
| - Bug in :meth:`DataFrame.any` with ``axis=1`` and ``bool_only=True`` ignoring the ``bool_only`` keyword (:issue:`32432`) | |||
| - Bug in :meth:`Series.equals` where a ``ValueError`` was raised when numpy arrays were compared to scalars (:issue:`35267`) | |||
| - | |||
| - Bug in :meth:`DataFrame.replace` and :meth:`Series.replace` incorrectly raising ``AssertionError`` instead of ``ValueError`` when invalid parameter combinations are passed (:issue:`36045`) | |||
| - Bug in :meth:`DataFrame.replace` and :meth:`Series.replace` with numeric values and string ``to_replace`` (:issue:`34789`) | |||
There was a problem hiding this comment.
Replace is not necessarily related to "numeric"
There was a problem hiding this comment.
replace uses equality to establish what to replace, so I think at a stretch this is OK.
issue is specifically about numeric values.
if regex was involved then maybe string section, but not relevant here.
what section do you suggest?
There was a problem hiding this comment.
The message says "and string ", so the issue was not only about numeric values it seems.
Personally I don't care that much, but if we are moving it, it should be an improvement, otherwise I would just leave it where it was
(in general "Numeric" is also a quite vague section)
There was a problem hiding this comment.
ahh I misread that, I thought it was replacing numeric values with strings.
will re-instate the other section and move it back.
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -354,7 +356,7 @@ Reshaping | |||
| - Bug in :func:`union_indexes` where input index names are not preserved in some cases. Affects :func:`concat` and :class:`DataFrame` constructor (:issue:`13475`) | |||
| - Bug in func :meth:`crosstab` when using multiple columns with ``margins=True`` and ``normalize=True`` (:issue:`35144`) | |||
| - Bug in :meth:`DataFrame.agg` with ``func={'name':<FUNC>}`` incorrectly raising ``TypeError`` when ``DataFrame.columns==['Name']`` (:issue:`36212`) | |||
| - | |||
| - Bug in :meth:`Series.transform` would give incorrect results or raise when the argument ``func`` was dictionary (:issue:`35811`) | |||
There was a problem hiding this comment.
transform doesn't reshape your series
There was a problem hiding this comment.
i've co-located it with DataFrame.agg. The issue is about a passing a dictionary of functions to Series.transform, which creates a DataFrame, even if the dict has only one entry. is that not reshaping?
in pandas\doc\source\whatsnew\v0.23.0.rst it was placed in Groupby section. move it there or create a new section?
There was a problem hiding this comment.
or maybe change section header to Reshaping/reductions/transformations
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff