BUG: alignment changing index on input series #36503
Conversation
pandas/core/generic.py
Outdated
| @@ -8835,6 +8839,10 @@ def _align_series( | |||
| if is_datetime64tz_dtype(left.index.dtype): | |||
| if left.index.tz != right.index.tz: | |||
| if join_index is not None: | |||
| # GH#33671 ensure we don't change the index on | |||
| # our original Series | |||
| left = left.copy(deep=False) | |||
There was a problem hiding this comment.
you don't need to deep copy, just .copy() as that copies the data; here we just need to avoid mutating the index, no?
There was a problem hiding this comment.
isnt that what deep=False means?
There was a problem hiding this comment.
oh woa, yes, i would remove the param then, its confusing
There was a problem hiding this comment.
if you can remove here and above the deep keyword
There was a problem hiding this comment.
i prefer to be explicit about this being non-deep
There was a problem hiding this comment.
would prefer to just use copy, this is not the pattern we use; your comment is explanatory.
|
also i think this needs a whatsnew bug fix reshaping note |
|
whatsnew added + green |
pandas/core/generic.py
Outdated
| @@ -8835,6 +8839,10 @@ def _align_series( | |||
| if is_datetime64tz_dtype(left.index.dtype): | |||
| if left.index.tz != right.index.tz: | |||
| if join_index is not None: | |||
| # GH#33671 ensure we don't change the index on | |||
| # our original Series | |||
| left = left.copy(deep=False) | |||
There was a problem hiding this comment.
if you can remove here and above the deep keyword
pandas/core/generic.py
Outdated
| @@ -8835,6 +8839,10 @@ def _align_series( | |||
| if is_datetime64tz_dtype(left.index.dtype): | |||
| if left.index.tz != right.index.tz: | |||
| if join_index is not None: | |||
| # GH#33671 ensure we don't change the index on | |||
| # our original Series | |||
| left = left.copy(deep=False) | |||
There was a problem hiding this comment.
would prefer to just use copy, this is not the pattern we use; your comment is explanatory.
|
updated + greenasitgets |
* BUG: alignment changing index on input series * whatsnew * remove deep=False
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff