REF: share fillna #36488
Merged
REF: share fillna #36488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Missing-data
jreback
approved these changes
Sep 21, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
|
|
||
| if mask.any(): | ||
| if method is not None: | ||
| func = missing.get_fill_func(method) |
There was a problem hiding this comment.
get_fill_func returns the 1d versions pad and backfill, doesn't this mixin also need to also support 2d EAs?
There was a problem hiding this comment.
eventually yes. but it wont break anything user-facing until we start backing DTBlock/TDBlock directly by DTA/TDA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Near-identical implementations in DatetimeLikeArray and PandasArray