Skip to content

CI: xfail html test #36467 #36468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CI: xfail html test #36467 #36468

wants to merge 1 commit into from

Conversation

fangchenli
Copy link
Member

Part of #36467

@simonjayhawkins simonjayhawkins added CI Continuous Integration IO HTML read_html, to_html, Styler.apply, Styler.applymap labels Sep 19, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1.3 milestone Sep 19, 2020
@simonjayhawkins
Copy link
Member

I'm fairly certain that i've seen this on the backports too. so can either backport this or merge to master and I could backport if I see it again.

@jreback
Copy link
Contributor

jreback commented Sep 19, 2020

are we sure this is not coming from something inside read_html? eg something we are doing

@simonjayhawkins
Copy link
Member

are we sure this is not coming from something inside read_html? eg something we are doing

I guess we will be keeping the issue open until we are sure, but the problem will be less visible of course.

@alimcmaster1
Copy link
Member

are we sure this is not coming from something inside read_html? eg something we are doing

Agree - I think I diagnosed the root cause here: #36480 (doesn't actually solve the problem though)

jbrockmendel
jbrockmendel reviewed Sep 19, 2020
View reviewed changes
pandas/tests/io/test_html.py
@@ -121,6 +121,7 @@ def test_to_html_compat(self):
res = self.read_html(out, attrs={"class": "dataframe"}, index_col=0)[0]
tm.assert_frame_equal(res, df)

@pytest.mark.xfail(reason="ResourceWarning from html5lib #36467", strict=False)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no way to make this strict?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how. Let me think abouit it.

@jreback
Copy link
Contributor

jreback commented Sep 19, 2020

yeah i think we should NOT suppress these as they tend to get ignored

@simonjayhawkins
Copy link
Member

yeah i think we should NOT suppress these as they tend to get ignored

agree since it appears issues can get closed and the xfails not removed. eg. #35660 (have opened #36524)

@simonjayhawkins simonjayhawkins removed this from the 1.1.3 milestone Sep 21, 2020
@fangchenli fangchenli deleted the html-warning branch September 23, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration IO HTML read_html, to_html, Styler.apply, Styler.applymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fangchenli @simonjayhawkins @jreback @alimcmaster1 @jbrockmendel