REF: use BlockManager.to_native_types in formatting code #36417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -631,6 +631,13 @@ def replace_list( | |||
| bm._consolidate_inplace() | |||
| return bm | |||
|
|
|||
| def to_native_types(self, **kwargs) -> "BlockManager": | |||
There was a problem hiding this comment.
It's the name that the blocks also use..
There was a problem hiding this comment.
It's not an informative name there either
There was a problem hiding this comment.
Then I am tempted to say "Go for it" .. ;)
I am well aware and fully agree that the whole "native types" terminology is confusing, but it is used in quite some places (not only the Block method, but also the Index helper methods). So fully on board with changing it, but that's a bigger change than just trying to remove the internals leakage in the csv code what I am doing here.
There was a problem hiding this comment.
yeah this can be updated / changed later
|
LGTM |
jreback
approved these changes
Sep 17, 2020
| @@ -631,6 +631,13 @@ def replace_list( | |||
| bm._consolidate_inplace() | |||
| return bm | |||
|
|
|||
| def to_native_types(self, **kwargs) -> "BlockManager": | |||
There was a problem hiding this comment.
yeah this can be updated / changed later
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
Sep 17, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up on #36150