CLN: Clean test_arithmetic.py #36390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaxton
added
Clean
Testing
mroeschke
reviewed
Sep 15, 2020
| @@ -553,68 +551,83 @@ def test_comparison_tuples(self): | |||
| expected = Series([True, False]) | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
| def test_comparison_operators_with_nas(self): | |||
| @pytest.mark.parametrize("op", ["lt", "le", "gt", "ge", "eq", "ne"]) | |||
There was a problem hiding this comment.
I think these exist as dunder strings in the all_compare_operators fixture
jreback
approved these changes
Sep 15, 2020
| @@ -271,7 +271,6 @@ def test_comparison_flex_basic(self): | |||
| tm.assert_series_equal(left.gt(right), left > right) | |||
| tm.assert_series_equal(left.ge(right), left >= right) | |||
|
|
|||
| # axis | |||
| for axis in [0, None, "index"]: | |||
There was a problem hiding this comment.
could parameterize here (might have to split the test)
| @@ -280,7 +279,6 @@ def test_comparison_flex_basic(self): | |||
| tm.assert_series_equal(left.gt(right, axis=axis), left > right) | |||
| tm.assert_series_equal(left.ge(right, axis=axis), left >= right) | |||
|
|
|||
| # | |||
| msg = "No axis named 1 for object type" | |||
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
Sep 17, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General cleaning (i.e., replacing for loops) trying to make these easier to follow / debug