Skip to content

single example for release notes #3639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2013
Merged

single example for release notes #3639

merged 1 commit into from
May 19, 2013

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented May 17, 2013

No description provided.

@cpcloud
Copy link
Member Author

cpcloud commented May 17, 2013

@jreback the requested example for release notes

@jreback
Copy link
Contributor

jreback commented May 17, 2013

@cpcloud that must have been a typo, I meant simple.....just put whatever you think a user would want to know

fix up rough edges of docs and add a more thorough test for nested dicts

fix unintended example
@cpcloud
Copy link
Member Author

cpcloud commented May 17, 2013

@jreback there are two examples in the rls notes now: 1 regex and 1 string (both from the linked-to docs), does that suffice? i also fixed up some typos in the examples and added a more thorough test for nested dicts of regexs

@jreback
Copy link
Contributor

jreback commented May 18, 2013

@cpcloud this looks good.....i'll leave open a day or 2...(I always tend to think of something to change 1 second after its merged)....:)

@cpcloud
Copy link
Member Author

cpcloud commented May 18, 2013

Sounds good.
On May 17, 2013 8:58 PM, "jreback" [email protected] wrote:

@cpcloud https://github.com/cpcloud this looks good.....i'll leave open
a day or 2...(I always tend to think of something to change 1 second after
its merged)....:)


Reply to this email directly or view it on GitHubhttps://github.com//pull/3639#issuecomment-18092823
.

jreback added a commit that referenced this pull request May 19, 2013
@jreback jreback merged commit c468d2f into pandas-dev:master May 19, 2013
@cpcloud cpcloud deleted the replace-with-regex-2285 branch May 22, 2013 02:01
@cpcloud cpcloud restored the replace-with-regex-2285 branch May 22, 2013 02:02
@cpcloud cpcloud deleted the replace-with-regex-2285 branch May 22, 2013 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants