Skip to content

ADMIN: Auto-label PRs for review #36349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2020
Merged

ADMIN: Auto-label PRs for review #36349

merged 1 commit into from
Sep 18, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Sep 14, 2020

Not certain this will work, but nonetheless I think something like this would be helpful (analogous to "Needs Triage" for issues)

@dsaxton dsaxton changed the title CI: Auto-label PRs for review ADMIN: Auto-label PRs for review Sep 14, 2020
@rhshadrach
Copy link
Member

At what point does the "Needs Review" tag get removed?

@dsaxton
Copy link
Member Author

dsaxton commented Sep 14, 2020

At what point does the "Needs Review" tag get removed?

I think it'd be the judgement of whoever is doing the reviewing, but initial thought is to take it down as soon as initial feedback is given (so the label means something like "not yet looked at"; so you could untag this one 😄). I'm imagining a way of making it easier to do "visual triage" when looking at the PR list (and also to have meaningful exemptions if the linked stale PR action gets merged).

@rhshadrach
Copy link
Member

That makes sense. I might even think of going further, to untag if the PR "has legs". That is, if it appears to be going in the right direction, even if more refinement is needed.

@dsaxton dsaxton added Admin Administrative tasks related to the pandas project and removed Needs Review labels Sep 15, 2020
@simonjayhawkins
Copy link
Member

I'm happy with this in principal since sometimes I look at the PR list for PRs without comments but that misses PRs where the author has added additional comments outside the OP.

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I see no harm in trying this out

@jreback jreback added this to the 1.2 milestone Sep 18, 2020
@jreback jreback merged commit d2e958b into pandas-dev:master Sep 18, 2020
@jreback
Copy link
Contributor

jreback commented Sep 18, 2020

sure

@dsaxton dsaxton deleted the auto-label-prs branch September 18, 2020 22:11
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Administrative tasks related to the pandas project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants