-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ADMIN: Auto-label PRs for review #36349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
At what point does the "Needs Review" tag get removed? |
I think it'd be the judgement of whoever is doing the reviewing, but initial thought is to take it down as soon as initial feedback is given (so the label means something like "not yet looked at"; so you could untag this one 😄). I'm imagining a way of making it easier to do "visual triage" when looking at the PR list (and also to have meaningful exemptions if the linked stale PR action gets merged). |
That makes sense. I might even think of going further, to untag if the PR "has legs". That is, if it appears to be going in the right direction, even if more refinement is needed. |
I'm happy with this in principal since sometimes I look at the PR list for PRs without comments but that misses PRs where the author has added additional comments outside the OP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I see no harm in trying this out
sure |
Not certain this will work, but nonetheless I think something like this would be helpful (analogous to "Needs Triage" for issues)