ENH/BUG: consistently cast strs to datetimelike for searchsorted #36346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sure, i guess need a whatsnew for this |
…ify-validators-searchsorted
|
whatsnew added + green |
…ify-validators-searchsorted
|
sure |
|
FYI im planning PRs to make cast_str=True in all of the validator method in that file for internal consistency (and ideally to end up with fewer methods) |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
Sep 17, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffATM we are pretty inconsistent in how we handle strings for (DTI|TDI|PI|Series).searchsorted. The underlying EAs will cast scalar strings but not Sequene[str]. The Indexes will raise on both scalars and sequences. Series follows the EA and casts "2016-01-01" but not
["2016-01-01"].This makes us consistently cast in all cases.