PERF: styler uuid control and security #36345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attack68
changed the title
# Conflicts: # doc/source/whatsnew/v1.2.0.rst
jreback
requested changes
Sep 13, 2020
WillAyd
requested changes
Sep 17, 2020
jreback
approved these changes
Sep 19, 2020
|
lgtm. @WillAyd if you have any remaining comments. |
WillAyd
approved these changes
Sep 19, 2020
|
Thanks @attack68 |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffStyleruuid is randomly generated from 16bytes, or 128bit entropy, which is poorly formatted for data transmission over the web.Styleruuid1 is super-ceded by uuid4 which is more network secure.This PR addresses the two above items by switching uuid method, and then coding the default entropy to 5 characters (20bit) which should be more than sufficient to avoid HTML table collision on a webpage, but make substantial data transfer savings for large tables.
uuid length remains configurable.