BUG: iloc.__setitem__ with DataFrame value, multiple blocks, non-unique columns #36337
Conversation
jbrockmendel
changed the title
|
does this directly close an issue? |
jreback
added
the
Indexing
| v = self._align_series( | ||
| tuple(sub_indexer), value[item], multiindex_indexer | ||
| ) | ||
| else: |
There was a problem hiding this comment.
what is the end goal here?
There was a problem hiding this comment.
i dont understand the question. 1718-1728 is just an indented version of what we have in the status quo
There was a problem hiding this comment.
it looks like you separated out the cases and duplicated the code. So is this making it easier to understand, later refactoring, ?
There was a problem hiding this comment.
its similar but not identical. this chunk is aligning by label while the chunk above is aligning positionally.
yes, i do hope to refactor this method before too long
There was a problem hiding this comment.
ok cool
yes, i do hope to refactor this method before too long
yeah these indexing routines defintely need some TLC
No, stumbled on this bug yesterday |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff