Skip to content

ERR: Cartesian product error #36335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2020
Merged

Conversation

TAJD
Copy link
Contributor

@TAJD TAJD commented Sep 13, 2020

Added a test to trigger the reported error using code from the issue. An if statement was included to return a more helpful error message - borrowing the solution from the issue.

Replacement of this pull request.

@dsaxton dsaxton changed the title Cartesian product error ERR: Cartesian product error Sep 13, 2020
@dsaxton dsaxton added the Error Reporting Incorrect or improved errors from pandas label Sep 13, 2020
Copy link
Member

@dsaxton dsaxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @TAJD

@jreback jreback added this to the 1.2 milestone Sep 13, 2020
@jreback jreback merged commit aa6298f into pandas-dev:master Sep 13, 2020
@jreback
Copy link
Contributor

jreback commented Sep 13, 2020

thanks @TAJD

@TAJD TAJD deleted the cartesian_product_error branch September 13, 2020 20:41
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Calling cartesian_product with large combinatorial space overflows int64 gives misleading errors
3 participants