REF: de-duplicate _wrap_joined_index in MultiIndex #36313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Sep 12, 2020
| if isinstance(self, ABCMultiIndex): | ||
| name = self.names if self.names == other.names else None | ||
| else: | ||
| name = get_op_result_name(self, other) |
There was a problem hiding this comment.
hmm why can't we do this in get_op_result_name?
There was a problem hiding this comment.
i considered that, decided against it because it meant additional overhead in a lot of places
jreback
approved these changes
Sep 13, 2020
| if isinstance(self, ABCMultiIndex): | ||
| name = self.names if self.names == other.names else None | ||
| else: | ||
| name = get_op_result_name(self, other) |
| @@ -152,6 +153,25 @@ def _codes_to_ints(self, codes): | |||
| return np.bitwise_or.reduce(codes, axis=1) | |||
|
|
|||
|
|
|||
| def names_compat(meth): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #36282
We'll also be able to clean up MultiIndex special-casing in _reindex_non_unique. I expect others but cant say for sure yet.