Skip to content

PERF: get_dtype_kinds #36309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

Upshot: avoid doing lots of non-performant is_foo_dtype checks.

This fixes a little more than half of the performance hit in the benchmark discussed in #34683.

@jreback jreback added Dtype Conversions Unexpected or buggy dtype conversions Performance Memory or execution speed performance labels Sep 12, 2020
@jreback jreback added this to the 1.2 milestone Sep 12, 2020
@jreback jreback merged commit 2da7c34 into pandas-dev:master Sep 12, 2020
@jreback
Copy link
Contributor

jreback commented Sep 12, 2020

sure, do we have sufficient bencharmarks for this?

@jbrockmendel jbrockmendel deleted the perf-get_dtype_kinds branch September 12, 2020 20:55
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dtype Conversions Unexpected or buggy dtype conversions Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants