Skip to content

REGR: Fix IntegerArray unary ops regression #36303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 13, 2020
Merged

REGR: Fix IntegerArray unary ops regression #36303

merged 12 commits into from
Sep 13, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Sep 12, 2020

@dsaxton dsaxton added NA - MaskedArrays Related to pd.NA and nullable extension arrays Regression Functionality that used to work in a prior pandas version labels Sep 12, 2020
@dsaxton dsaxton added this to the 1.1.3 milestone Sep 12, 2020
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@@ -1055,6 +1055,19 @@ def any_nullable_int_dtype(request):
return request.param


@pytest.fixture(params=tm.SIGNED_EA_INT_DTYPES)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@jreback jreback merged commit 73cdfc4 into pandas-dev:master Sep 13, 2020
@dsaxton
Copy link
Member Author

dsaxton commented Sep 13, 2020

@jreback @simonjayhawkins Should this change be backported?

@simonjayhawkins
Copy link
Member

will do it after merged the two open ones. if meeks... fails can't retrigger and need to do it manually

@dsaxton dsaxton deleted the unary-ops-nullable-int branch September 13, 2020 13:05
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NA - MaskedArrays Related to pd.NA and nullable extension arrays Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Unary minus raises for series with Int64Dtype
4 participants