BUG: fix duplicate entries in LaTeX List of Tables when using longtable environments #36297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should target 1.2 as there was a large refactor in this code (which u already did), just move the note |
ivanovmg
reviewed
Sep 14, 2020
ivanovmg
approved these changes
Sep 16, 2020
|
@ivanovmg if you'd have a look. |
@jreback, this looks good to me. However, if there are other modifications to longtable in future, we may want to redefine the method |
jreback
approved these changes
Sep 19, 2020
|
lgtm ping on green. |
|
thanks @jeschwar |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longtable,label, andcaptionwith LaTeX #34360black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff