CLN: _wrap_applied_output #36260
Merged
CLN: _wrap_applied_output #36260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else: | ||
| result = DataFrame(values, index=key_index, columns=[self._selection]) | ||
| self._insert_inaxis_grouper_inplace(result) | ||
| return result |
There was a problem hiding this comment.
looks like this line isnt covered (the equivalent line isnt covered in master, so not necessarily a problem for this PR). any chance it is unreachable and can be removed?
There was a problem hiding this comment.
Added test to cover it.
|
Changing |
|
@jbrockmendel: Thanks for the review. Regarding the rearrangement, I thought it was better to separate "not a series" and "is a series" cases. Before they were (needlessly IMO) intertwined. |
|
thanks @rhshadrach yeah groupby has built up over the years to be long / complicated functions, thanks for working on this. |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff