DOC: Improve Index docstrings

[Nikhil1O1]

Index is now described as List instead of Set

• closes DOC: index described as a "set" but permits duplicates -- change to multiset or list? #36170
• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff
• whatsnew entry

[WillAyd]

Lgtm

[onshek]

Lgtm

Sorry for stepping in, I think it's not accurate enough according to #36170 (comment)

[Nikhil1O1]

Some tests are failing... I don't recall changing anything else accept the documentation, Why is this even happening?
any idea how to fix this?

[dsaxton]

Some tests are failing... I don't recall changing anything else accept the documentation, Why is this even happening?
any idea how to fix this?

The CI failures are unrelated to this change

[topper-123]

In my opinion a set implies that values are unique, which isn’t true for indexes. Maybe “sequence” is better?

[dsaxton]

In my opinion a set implies that values are unique, which isn’t true for indexes. Maybe “sequence” is better?

@topper-123 That makes sense. I also think perhaps the whole thing could be rewritten to something like "Immutable sequence used for indexing and alignment." (remove references to ndarrays, sets, or being ordered since none apply). What do you think?

[Nikhil1O1]

Looks more appropriate to me as well
Shall I improve it?
@dsaxton @topper-123

[dsaxton]

Rather than opening a separate PR can you make both changes here?

[Nikhil1O1]

Sure

[Nikhil1O1]

@dsaxton I did the required changes. This should do... Right?

[dsaxton]

Thanks @Nikhil1O1