CLN: simplify Categorical comparisons #36237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsaxton
reviewed
Sep 9, 2020
Comment on lines
102
to
+104
| mask = (self._codes == -1) | (other_codes == -1) | ||
| if mask.any(): | ||
| # In other series, the leads to False, so do that here too | ||
| if opname == "__ne__": | ||
| ret[(self._codes == -1) & (other_codes == -1)] = True | ||
| else: | ||
| ret[mask] = False | ||
| ret[mask] = fill_value |
There was a problem hiding this comment.
Does it make sense to simplify further to only ret[(self._codes == -1) | (other_codes == -1)] = fill_value (or remove the if mask.any())?
There was a problem hiding this comment.
I'm OK with it either way; we use the if mask.any() check elsewhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not as much as I had hoped, but not nothing.