Skip to content

CLN: re-use invalid_comparison in Categorical comparisons #36229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2020
Merged

CLN: re-use invalid_comparison in Categorical comparisons #36229

merged 1 commit into from
Sep 8, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

@topper-123 topper-123 added Categorical Categorical Data Type Clean labels Sep 8, 2020
@topper-123 topper-123 added this to the 1.2 milestone Sep 8, 2020
topper-123
topper-123 approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green.

@jreback jreback merged commit 7d16224 into pandas-dev:master Sep 8, 2020
@jreback
Copy link
Contributor

jreback commented Sep 8, 2020

great

@jbrockmendel jbrockmendel deleted the ref-cat-invalid_comparison branch September 8, 2020 23:10
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@jbrockmendel
CLN: re-use invalid_comparison in Categorical comparisons (pandas-dev…
6e232ac 
…#36229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topper-123 topper-123 topper-123 approved these changes

Assignees
No one assigned
Labels
Categorical Categorical Data Type Clean
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @jreback @topper-123