BUG: GH36212 DataFrame agg() raises error when DataFrame column name is name
#36224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Sep 8, 2020
leonarduschen
force-pushed
the
fix-df-agg-self-name
branch
from
bc9fa34 to
b63517c
Compare
|
Hello @leonarduschen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-12 21:56:55 UTC |
rhshadrach
reviewed
Sep 9, 2020
jreback
requested changes
Sep 9, 2020
leonarduschen
force-pushed
the
fix-df-agg-self-name
branch
from
fd6fc51 to
07afd3e
Compare
leonarduschen
force-pushed
the
fix-df-agg-self-name
branch
from
07afd3e to
a863e0d
Compare
|
@jreback @rhshadrach done! |
leonarduschen
changed the title
namename
leonarduschen
commented
Sep 12, 2020
rhshadrach
requested changes
Sep 12, 2020
jreback
requested changes
Sep 12, 2020
There was a problem hiding this comment.
@leonarduschen can you add a whatsnew note, 1.2, bug fix section in reshaping section
rhshadrach
approved these changes
Sep 13, 2020
jreback
approved these changes
Sep 13, 2020
|
thanks @leonarduschen |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff