Skip to content

CLN: w3 formatting #36223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2020
Merged

CLN: w3 formatting #36223

merged 2 commits into from
Sep 8, 2020

Conversation

attack68
Copy link
Contributor

@attack68 attack68 commented Sep 8, 2020

Cleans a very minor formatting error to be consistent with w3schools specification.

colspan=2 ---> colspan="2"

Note this generally has no effect in browsers parsing HTML.

@attack68 attack68 changed the title clean: w3 formatting CLN: w3 formatting Sep 8, 2020
@MarcoGorelli
Copy link
Member

Thanks @attack68 - is it possible to write a test for this?

@attack68
Copy link
Contributor Author

attack68 commented Sep 8, 2020

seemed like overkill, but included..

@jreback jreback added this to the 1.2 milestone Sep 8, 2020
@jreback jreback added the Styler conditional formatting using DataFrame.style label Sep 8, 2020
@jreback jreback merged commit 9e3b8df into pandas-dev:master Sep 8, 2020
@jreback
Copy link
Contributor

jreback commented Sep 8, 2020

thanks @attack68

reason for the tests is to lock down the behavior; otherwise someone can accidently revert this and we wouldn't know :->

@attack68 attack68 deleted the bug_w3_format branch September 9, 2020 05:11
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Styler conditional formatting using DataFrame.style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: pandas dataframe style render produces incorrect html with multiindex
3 participants