-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
REF: eliminate method _write() in json writers #36218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fdbed7b
REF: eliminate mediator method _write
ivanovmg 1b89aba
REF: extract property obj_to_write
ivanovmg efd6134
FIX: import order
ivanovmg 20b9b5b
TYP: add annotation to obj_to_write
ivanovmg 6b70c0c
Merge branch 'master' into bug_36211
ivanovmg 9bb9be2
Merge branch 'master' into bug_36211
ivanovmg e1fa7df
Merge branch 'master' into bug_36211
ivanovmg 23afd99
Merge branch 'master' into bug_36211
ivanovmg 795c4ac
TYP: fix for obj_to_write
ivanovmg 48bb36f
Merge branch 'master' into bug_36211
ivanovmg f2e3a3b
Merge branch 'master' into bug_36211
ivanovmg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm why do we need to do this now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know. I simply used the original implementation and moved whatever assignments were in
_write
into__init__
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh OK - I see what was done here. Let's not assign to
self.obj
as that will mess with the idempotencyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We assign to
self.obj
at the moment of the writer initialization, not when calling a method. So, I would argue that it is not harmful.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it is confusing to change what
self.obj
is for certain orients - would prefer not to do this