CLN: remove unnecessary trailing commas on issues #35925

[satrio-hw]

#35925

• pandas/tests/arrays/categorical/test_replace.py
• pandas/tests/arrays/sparse/test_array.py
• pandas/tests/arrays/test_array.py
• pandas/tests/arrays/test_timedeltas.py
• pandas/tests/base/test_conversion.py
• pandas/tests/dtypes/test_missing.py
• pandas/tests/extension/base/methods.py
• pandas/tests/extension/test_sparse.py
• pandas/tests/frame/indexing/test_setitem.py

please give me a feedback if there is something that I have to change.. thank you before

[MarcoGorelli]

Hi @satrio-hw

You will need to run black again on the files you've modified to make sure they won't be changed

[satrio-hw]

@MarcoGorelli I've tried to rerun black on modified files, some of them revert back with commas on it.. And still got some error when chacking after I push back.. Something I could do to fix this?

[MarcoGorelli]

@satrio-hw I think you can not include pandas/tests/arrays/sparse/test_array.py as part of this pull request, as the two versions of black will not agree on how to reformat it and we need to the trailing comma there. So, we'll update it when we update the version of black. The rest of your PR looks good!

[satrio-hw]

@MarcoGorelli I've revert back pandas/tests/arrays/sparse/test_array.py to origin/master. To make sure I've run a command ./ci/code_checks.sh lint and check there is only one changes to commit.. linting check done successful after pushing changes, but now I got failed tests on pandas-dev.pandas

is there something wrong in the procedures that I've done? thanks before

[MarcoGorelli]

This looks correct now, thanks, the CI error should be unrelated - can you fetch and merge master, then push, to restart the CI process and get it green?

[satrio-hw]

@MarcoGorelli I've fetch and merge master, and push it again.. now all green.. thank you very much for your guidance

[jreback]

thanks @satrio-hw