BUG: Reindex data if plotting time/period index (GH3601) #3619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added a test and update release notes. squashed into one commit |
|
@jreback, ok to merge this? |
|
@dieterv77 looks good to me |
dieterv77
added a commit
that referenced
this pull request
May 17, 2013
BUG: (GH3601) Reindex data if reordering time/period index
|
Since the datetimeindex supplies the labels here, why it it mandatory Hardcoding a sort fixes one problem (GH3061), but creates another. Also, @dieterv77 , please mark issues by the miletsone they go into, if you're merging |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to push this fix to see if it looked OK and let the Travis build start.
If it looks ok, i will add something in the release notes and try to write a proper test.