REF: use _validate_foo pattern in Categorical #36181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 7, 2020
| ) | ||
| return code[0] | ||
|
|
||
| def _validate_searchsorted_value(self, value): |
There was a problem hiding this comment.
can you type as much as possible
There was a problem hiding this comment.
sure, there are a few of these and im planning to do a typing pass at the end
jreback
added
Categorical
jreback
approved these changes
Sep 7, 2020
jbrockmendel
added a commit
to jbrockmendel/pandas
that referenced
this pull request
Sep 8, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how we did it in datetimelike, eventually these validator methods are going to end up sharing most of their code