STY: de-privatize names imported across modules #36178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 7, 2020
asv_bench/benchmarks/sparse.py
Outdated
| @@ -71,7 +71,7 @@ def setup(self): | |||
| s.index = MultiIndex.from_product([range(10)] * 4) | |||
| self.ss = s.astype("Sparse") | |||
|
|
|||
| def time_sparse_series_to_coo(self): | |||
| def timesparse_series_to_coo(self): | |||
pandas/core/index.py
Outdated
| @@ -19,7 +19,7 @@ | |||
| ensure_index_from_sequences, | |||
| get_objs_combined_axis, | |||
| ) | |||
| from pandas.core.indexes.multi import _sparsify # noqa:F401 | |||
| from pandas.core.indexes.multi import sparsify_labels as _sparsify # noqa:F401 | |||
There was a problem hiding this comment.
can you make the edit inside this
There was a problem hiding this comment.
not sure what you're asking for here
There was a problem hiding this comment.
don't use the as import
just update to use sparsify_labels instead of _sparsify
|
updated+green |
jreback
approved these changes
Sep 8, 2020
jreback
reviewed
Sep 8, 2020
| @@ -19,7 +19,7 @@ | |||
| ensure_index_from_sequences, | |||
| get_objs_combined_axis, | |||
| ) | |||
| from pandas.core.indexes.multi import _sparsify # noqa:F401 | |||
| from pandas.core.indexes.multi import sparsify_labels # noqa:F401 | |||
There was a problem hiding this comment.
actually i think you can just remove this line entirely (its not used inside)
There was a problem hiding this comment.
i mean, nothing is used in this file
There was a problem hiding this comment.
ok, then wonder if we need this at all here (and maybe even re-evaluate all of these exports); but let's do later.
There was a problem hiding this comment.
i think the idea is to remove the file in 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting close to the end of this and enabling a code_check