Skip to content

Move sort index to generic #36177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Sep 15, 2020
Merged

Move sort index to generic #36177

merged 23 commits into from
Sep 15, 2020

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Sep 6, 2020 •
edited
Loading

jreback
jreback requested changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. yeah this is something have been wanting to clean up for a while! some comments.

@jreback jreback added the Refactor Internal refactoring of code label Sep 7, 2020
@jreback jreback added this to the 1.2 milestone Sep 7, 2020
jreback
jreback requested changes Sep 8, 2020
View reviewed changes
jreback
jreback requested changes Sep 8, 2020
View reviewed changes
jreback
jreback requested changes Sep 11, 2020
View reviewed changes
jreback
jreback requested changes Sep 13, 2020
View reviewed changes
@jreback jreback added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label Sep 15, 2020
@jreback jreback merged commit 6929e26 into pandas-dev:master Sep 15, 2020
@jreback
Copy link
Contributor

jreback commented Sep 15, 2020

thanks @VirosaLi very nice!

@fangchenli fangchenli deleted the move-sort_index-to-generic branch September 15, 2020 15:14
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@fangchenli
Move sort index to generic (pandas-dev#36177)
dc8d42c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

CLN/TST: move consoliate sort_index to core/generic.py
2 participants
@fangchenli @jreback