Clarify docs for df.to_sql chunksize
#36172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
requested changes
Sep 9, 2020
| @@ -2634,7 +2634,8 @@ def to_sql( | |||
| `index` is True, then the index names are used. | |||
| A sequence should be given if the DataFrame uses MultiIndex. | |||
| chunksize : int, optional | |||
| Specify the number of rows in each batch to be written at a time. | |||
| If batching is enabled via `method`, specify the number of rows in | |||
There was a problem hiding this comment.
Not overly familiar with our implementation but I think that this isn't tied to method as described here - are you seeing something definitely in the code that leads you to believe this?
There was a problem hiding this comment.
I commented on the issue about it: #35891, let's discuss there further (but indeed it doesn't seem to depend on the method based on the code)
jorisvandenbossche
added
the
Needs Discussion
|
Thanks for the PR but looks like more discussion is needed in original issue before doing anything here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chunksizeseems to be ignored by default. #35891black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffNote: this is a docs pr, so not adding tests or a whatsnew entry.